Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛Fix CPU burning on ironic-log-watch when no ramdisk file is present #548

Merged
merged 1 commit into from
Sep 16, 2024
Merged

🐛Fix CPU burning on ironic-log-watch when no ramdisk file is present #548

merged 1 commit into from
Sep 16, 2024

Conversation

blallau
Copy link

@blallau blallau commented Aug 30, 2024

Use inotifywait instead of an infinite loop.

Fixes #547

@metal3-io-bot metal3-io-bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 30, 2024
@metal3-io-bot
Copy link
Contributor

Hi @blallau. Thanks for your PR.

I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@metal3-io-bot metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 30, 2024
@blallau blallau changed the title Fix CPU burning on ironic-log-watch when no ramdisk file is present 🐛Fix CPU burning on ironic-log-watch when no ramdisk file is present Aug 30, 2024
@tuminoid
Copy link
Member

tuminoid commented Sep 2, 2024

We have #540 already addressing similar issue, can you collaborate on that PR?

@blallau blallau mentioned this pull request Sep 2, 2024
Closed
@tuminoid
Copy link
Member

tuminoid commented Sep 3, 2024

/ok-to-test

@metal3-io-bot metal3-io-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 3, 2024
@tuminoid
Copy link
Member

tuminoid commented Sep 3, 2024

Please fix shellcheck issues, preferably use curlys around variables as well, and when linting is green, trigger integration tests.

Fix CPU burning on ironic-log-watch when no ramdisk file is present
a519547 
Use inotifywait on 'close_write' event instead of an infinite loop.
Inotifywait 'close_write' event usage allow to be sure that
tar file archive integrity is safe.

Signed-off-by: LALLAU Bertrand <blallau@github.com>
@blallau
Copy link
Author

blallau commented Sep 5, 2024

/retest

@tuminoid
Copy link
Member

tuminoid commented Sep 5, 2024

/retest

Retest won't run tests that are not run in the first place.
/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

@Rozzii Rozzii mentioned this pull request Sep 11, 2024
Closed
@tuminoid
Copy link
Member

Can you rebase, so the fix we have merged is included. Otherwise CI won't work.

@tuminoid
Copy link
Member

Can you rebase, so the fix we have merged is included. Otherwise CI won't work.

The official fix is in, so this should work now.
/retest

tuminoid
tuminoid reviewed Sep 16, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 16, 2024
@tuminoid
Copy link
Member

/cc @dtantsur

@derekhiggins
Copy link
Member

/approve
thanks

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekhiggins

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 16, 2024
@metal3-io-bot metal3-io-bot merged commit 7dfbbdf into metal3-io:main Sep 16, 2024
8 checks passed
elfosardo pushed a commit to elfosardo/ironic-image that referenced this pull request Oct 9, 2024
@openshift-merge-bot
Merge pull request metal3-io#548 from iurygregory/vmedia-issue-4.14
6f28a62 
[4.14] OCPBUGS-32266: redfish-virtualmedia fails on XFusion nodes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuminoid tuminoid tuminoid left review comments

@derekhiggins derekhiggins Awaiting requested review from derekhiggins

@iurygregory iurygregory Awaiting requested review from iurygregory

@dtantsur dtantsur Awaiting requested review from dtantsur

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ironic-log-watch: CPU at full capacity in case of no ramdisk file present
4 participants
@blallau @metal3-io-bot @tuminoid @derekhiggins