⚠️ Update ipxe version #533
Conversation
metal3-io-bot
added
the
size/XS
|
/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main |
OCPBUGS-37402: bump werkzeug
Dockerfile
Outdated
| cd ipxe/src && \ | ||
| RUN git clone https://github.com/ipxe/ipxe.git && \ | ||
| cd ipxe && \ | ||
| git reset --hard 9062544f6a0c69c249b90d21a08d05518aafc2ec && \ |
There was a problem hiding this comment.
How did you pick this version? It does not seem to be the latest. Let's leave a comment on what this version corresponds to (date, reason of picking).
Also, maybe it's time we introduce an argument for the iPXE version so that the users can revert more easily (and we can test new versions easier)?
There was a problem hiding this comment.
It's not the latest as unfortunately the latest does not work :/
Ideally I'm trying to take the update with small steps at a time, but I'll provide a better commit message with some of the most important changes.
Also good idea about the argument, I'll work on that too
This is a tentative to make ipxe more close to the current version and include some improvements and bug fixes. As a first step we build and install ipxe using a commit hash, as no stable versions have been released since December 2020. We point the ipxe commit hash to [1] from November 2021, so roughly a year of changes is included. To see the complete list of changes run: `git log --pretty=oneline 988d2c1..9062544` from a local clone of the ipxe repository. In general the changes included between the stable 1.21.1 version and the current chosen hash improve compatibility with recent gcc and build libraries, while fixing numerous bugs. This change also introduce a build arg to allow choosing the ipxe commit hash at container build time. [1] ipxe/ipxe@9062544 Signed-off-by: Riccardo Pittau <elfosardo@gmail.com>
elfosardo
changed the title
|
/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dtantsur The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
|
/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main |
1 similar comment
|
/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main |
|
/lgtm |
This is a tentative to make ipxe more close to the current version
and include some improvements and bug fixes.
As a first step we build and install ipxe using a commit hash,
as no stable versions have been released since December 2020.
We point the ipxe commit hash to [1] from November 2021, so
roughly a year of changes is included.
To see the complete list of changes run:
git log --pretty=oneline 988d2c1..9062544from a local clone of the ipxe repository.
In general the changes included between the stable 1.21.1
version and the current chosen hash improve compatibility
with recent gcc and build libraries, while fixing
numerous bugs.
This change also introduce a build arg to allow choosing
the ipxe commit hash at container build time.
[1] ipxe/ipxe@9062544