Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Remove dnf config-manager after its use #526

Merged
merged 1 commit into from
Jul 30, 2024
Merged

🌱 Remove dnf config-manager after its use #526

merged 1 commit into from
Jul 30, 2024

Conversation

elfosardo
Copy link
Member

@elfosardo elfosardo commented Jul 3, 2024 •
edited
Loading

We don't really need it in the final image

@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 3, 2024
@elfosardo elfosardo force-pushed the remove-dnf-config-mgr branch from 67b56f2 to 0376db8 Compare July 3, 2024 10:47
@tuminoid
Copy link
Member

tuminoid commented Jul 3, 2024

/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

Ironic is built in e2e, so it is a good test (we don't have separate build test anymore)

@elfosardo
Copy link
Member Author

/test metal3-centos-e2e-integration-test-main
issue with CI ?

@tuminoid
Copy link
Member

tuminoid commented Jul 3, 2024

/test metal3-centos-e2e-integration-test-main issue with CI ?

Just a random network flake. It is amazing how they happen in such basic operations such as git clone or download a binary :(

@elfosardo
Copy link
Member Author

/test metal3-ubuntu-e2e-integration-test-main

@elfosardo
Copy link
Member Author

/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

2 similar comments
@tuminoid
Copy link
Member

tuminoid commented Jul 5, 2024

/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

@tuminoid
Copy link
Member

tuminoid commented Jul 5, 2024

/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

@tuminoid
Copy link
Member

tuminoid commented Jul 5, 2024

I'm starting to think this has an effect on the failures (doesn't make sense tho), CI is quite stable otherwise....

@elfosardo
Copy link
Member Author

I'm starting to think this has an effect on the failures (doesn't make sense tho), CI is quite stable otherwise....

I'll retest once more

@elfosardo
Copy link
Member Author

/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

@elfosardo
Copy link
Member Author

@tuminoid this is really weird, the only thing I can think about is some dependencies being removed that are needed later
I'm testing CI here #527 just to verify it

@elfosardo
Remove dnf config-manager after its use
06df1f3 
We don't really need it in the final image

Signed-off-by: Riccardo Pittau <elfosardo@gmail.com>
@elfosardo elfosardo force-pushed the remove-dnf-config-mgr branch from 0376db8 to 06df1f3 Compare July 8, 2024 14:24
@elfosardo
Copy link
Member Author

/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

@elfosardo
Copy link
Member Author

/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

bash: line 1: minikube: command not found

@elfosardo
Copy link
Member Author

/test metal3-centos-e2e-integration-test-main

@dtantsur
Copy link
Member

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 25, 2024
@iurygregory
Copy link
Member

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 30, 2024
@metal3-io-bot metal3-io-bot merged commit c467d7e into metal3-io:main Jul 30, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iurygregory iurygregory Awaiting requested review from iurygregory

@zaneb zaneb Awaiting requested review from zaneb

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@elfosardo @tuminoid @dtantsur @metal3-io-bot @iurygregory