Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Update Makefile #525

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Conversation

elfosardo
Copy link
Member

@elfosardo elfosardo commented Jun 21, 2024

Introduce variable to set build container engine.
Build with podman by default.

@metal3-io-bot metal3-io-bot requested review from dtantsur and Rozzii June 21, 2024 08:28
@metal3-io-bot metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 21, 2024
Introduce variable to set build container engine.
Build with podman by default.

Signed-off-by: Riccardo Pittau <elfosardo@gmail.com>
@elfosardo
Copy link
Member Author

/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

Copy link
Member

@Rozzii Rozzii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 24, 2024
@dtantsur
Copy link
Member

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2024
@metal3-io-bot metal3-io-bot merged commit 720a070 into metal3-io:main Jun 24, 2024
9 checks passed
iurygregory pushed a commit to iurygregory/ironic-image that referenced this pull request Aug 1, 2024
…on-413

OCPBUGS-37116: Update eventlet version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants