WIP: 🐛 Fix permissions for /certs/ca directory #508
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
size/XS
|
Please fix the DCO. |
Signed-off-by: Mahnoor Asghar <masghar@redhat.com>
MahnoorAsghar
force-pushed
the
fix-permissions
branch
from
e16d0c8 to
4e8b0f1
Compare
|
New changes are detected. LGTM label has been removed. |
| @@ -23,7 +23,7 @@ chown "${IRONIC_USER}":"${IRONIC_GROUP}" /shared | |||
| # that need to have correct ownership as the entire ironic in BMO | |||
| # deployment shares a single fsGroup in manifest's securityContext | |||
| mkdir -p /certs/ca | |||
| chown "${IRONIC_USER}":"${IRONIC_GROUP}" /certs{,/ca} | |||
| chown -R "${IRONIC_USER}":"${IRONIC_GROUP}" /certs{,/ca} | |||
There was a problem hiding this comment.
On an another look, the original syntax does expand to cover both directories anyways, so it should be possible to create /certs/ca/ironic. Have you tested this actually fixes your issue?
There was a problem hiding this comment.
I am trying to build an OpenShift ironic-image to test this locally, will mark the PR as a WIP
|
/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main |
|
@MahnoorAsghar: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
MahnoorAsghar
changed the title
metal3-io-bot
added
the
do-not-merge/work-in-progress
|
The issue was resolved downstream, and an upstream fix is not needed. |
Bug OCPBUGS-34534: Disable installation of .pyc files through pip
The metal3-ironic-inspector pod is not able to create the /certs/ca directory and fails with the following error while executing /bin/tls-common.sh. This PR fixes this issue.