-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Add release-1.4 related changes #949
Conversation
/approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mboukhalfa, tuminoid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Before project-infra PR is in, no real tests are being run in release branch 1.4 btw. For this PR it is a benefit, but just a note. |
Also we need branch protection rules for release-1.4 |
/test-ubuntu-integration-release-1-4 |
checking if it can still trigger the test, because we need atleast one trigger for github to pick it up and then it could be added in the github branch protection. |
Branch protection added |
They're now in place for CAPM3 and IPAM, but we need to get the project-infra change in, and get the test triggered to add it GH required tests, yes. |
We should merge the trigger update here https://gerrit.nordix.org/c/infra/cicd/+/18061 and start using e2e /test-ubuntu-e2e-integration-release-1-4 I do not see a need to update jjbs with ansible trigger on 1.4 since we are deprecating it |
This is an automated cherry-pick of #944
/assign kashifest