✨ Add bond hash policy #708

shibaPuppy · 2022-09-06T18:41:37Z

https://github.com/openstack/ironic/blob/master/ironic/tests/unit/drivers/modules/network/json_samples/network_data.json#L31
Adds the bond hash policy feature added to Ironic.

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

metal3-io-bot · 2022-09-06T18:41:47Z

Hi @shibaPuppy. Thanks for your PR.

I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dtantsur

/ok-to-test

https://github.com/canonical/cloud-init/blob/main/cloudinit/sources/helpers/openstack.py#L679 seems to require bond_links actually? I'm not sure how the link you pasted proves it's optional.

shibaPuppy · 2022-09-07T14:02:04Z

@dtantsur
cloud-init code copies bond_links.
try to get the desired bond id value by putting an empty array in bond_links as shown below.

links:
- id: bond0
  type: bond
  ethernet_mac_address: ff:ff:ff:ff:ff:ff
  bond_links: [] # here empty array
- id: bond1
  type: bond
  ethernet_mac_address: 11:22:33:44:55:66
  bond_links:
    - eth0
    - eth1
....

metal3-io-bot · 2023-04-17T14:37:20Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues will close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle stale

shibaPuppy · 2023-04-25T16:16:35Z

@dtantsur
hi,
adds the bond hash policy feature added to Ironic.
please review

dtantsur · 2023-04-27T07:59:37Z

api/v1alpha5/metal3datatemplate_types.go

+	// +kubebuilder:validation:Enum="layer2";"layer3+4";"layer2+3"
+	// Selects the transmit hash policy used for port selection in balance-xor and 802.3ad modes
+	// +optional
+	BondHashPolicy string `json:"bond_xmit_hash_policy"`


The JSON name does not conform to the used standard and does not fully match the field name. Why not just bondHashPolicy?

dtantsur · 2023-04-27T07:59:44Z

api/v1beta1/metal3datatemplate_types.go

+	// +kubebuilder:validation:Enum="layer2";"layer3+4";"layer2+3"
+	// Selects the transmit hash policy used for port selection in balance-xor and 802.3ad modes
+	// +optional
+	BondHashPolicy string `json:"bond_xmit_hash_policy"`


dtantsur · 2023-04-27T08:00:36Z

baremetal/metal3data_manager.go

+			"mtu":                   link.MTU,
+			"ethernet_mac_address":  macAddress,
+			"bond_mode":             link.BondMode,
+			"bond_xmit_hash_policy": link.BondHashPolicy,


I cannot find this field in the network data schema. Where is it coming from?

@dtantsur
It does not exist in the network-data schema, but I confirmed that the code exists in the ironic sample & cloud-init.

https://github.com/openstack/ironic/blob/master/ironic/tests/unit/drivers/modules/network/json_samples/network_data.json#L31 Adds the bond hash policy feature added to Ironic.

Rozzii · 2023-10-03T10:17:30Z

/test-centos-e2e-integration-main
/test-ubuntu-integration-main

Rozzii · 2023-10-03T10:19:01Z

/test-centos-e2e-integration-main
/test-ubuntu-integration-main

Rozzii

/lgtm
Looks good as far as I can tell.

Rozzii · 2023-10-05T09:15:47Z

PTAL @kashifest @mboukhalfa @lentzi90

Rozzii · 2023-10-05T09:16:14Z

/cc @mboukhalfa @lentzi90 @adilGhaffarDev

kashifest · 2023-10-05T10:07:30Z

/test-ubuntu-e2e-features-main
/test-e2e-upgrade-main-from-release-0-5

Rozzii · 2023-10-05T10:21:55Z

@kashifest seems like the test haven't been triggered

kashifest · 2023-10-05T10:24:35Z

/test-ubuntu-e2e-feature-main

adilGhaffarDev

/lgtm

lentzi90 · 2023-10-05T11:02:20Z

/retitle ✨ Add bond hash policy

lentzi90 · 2023-10-05T11:03:34Z

/test-e2e-upgrade-main-from-release-1-5

kashifest · 2023-10-05T15:14:36Z

/test-ubuntu-e2e-feature-main

kashifest · 2023-10-05T15:15:00Z

/test-e2e-upgrade-main-from-release-1-5

kashifest · 2023-10-05T17:10:50Z

/approve

metal3-io-bot · 2023-10-05T17:10:57Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest, Rozzii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [kashifest]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

metal3-io-bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 6, 2022

metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 6, 2022

dtantsur requested changes Sep 7, 2022

View reviewed changes

metal3-io-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 7, 2022

shibaPuppy mentioned this pull request Sep 13, 2022

Change order for network-data #706

Closed

shibaPuppy force-pushed the bond branch from 68dcf54 to b2e2511 Compare September 19, 2022 09:51

metal3-io-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 17, 2023

metal3-io-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 25, 2023

shibaPuppy force-pushed the bond branch 2 times, most recently from 1b2a764 to 02704ad Compare April 25, 2023 16:12

metal3-io-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 25, 2023

shibaPuppy changed the title ~~Change to optional for network-data bond_link field~~ Add bond hash policy Apr 25, 2023

shibaPuppy requested a review from dtantsur April 25, 2023 16:15

shibaPuppy force-pushed the bond branch 2 times, most recently from 417dff1 to cff3208 Compare April 25, 2023 16:29

metal3-io-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 25, 2023

shibaPuppy force-pushed the bond branch from cff3208 to 88ff669 Compare April 25, 2023 16:34

metal3-io-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 25, 2023

dtantsur reviewed Apr 27, 2023

View reviewed changes

shibaPuppy force-pushed the bond branch 2 times, most recently from 7f57db9 to 71f9a5b Compare October 2, 2023 20:35

metal3-io-bot removed the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Oct 2, 2023

Add bond hash policy

6c4bfdc

https://github.com/openstack/ironic/blob/master/ironic/tests/unit/drivers/modules/network/json_samples/network_data.json#L31 Adds the bond hash policy feature added to Ironic.

shibaPuppy force-pushed the bond branch from 71f9a5b to 6c4bfdc Compare October 2, 2023 21:18

Rozzii removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 3, 2023

Rozzii approved these changes Oct 5, 2023

View reviewed changes

metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 5, 2023

metal3-io-bot requested review from adilGhaffarDev, lentzi90 and mboukhalfa October 5, 2023 09:16

adilGhaffarDev reviewed Oct 5, 2023

View reviewed changes

metal3-io-bot changed the title ~~Add bond hash policy~~ ✨ Add bond hash policy Oct 5, 2023

metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 5, 2023

metal3-io-bot merged commit 1bc274f into metal3-io:main Oct 5, 2023

lentzi90 mentioned this pull request Oct 11, 2023

✨ Enable mac address retrieved from annotations #1262

Merged

hardys mentioned this pull request Feb 21, 2024

CAPM3 lacks of options for bond interfaces #1466

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

✨ Add bond hash policy #708

✨ Add bond hash policy #708

shibaPuppy commented Sep 6, 2022 •

edited

Loading

metal3-io-bot commented Sep 6, 2022

dtantsur left a comment

shibaPuppy commented Sep 7, 2022 •

edited

Loading

metal3-io-bot commented Apr 17, 2023

shibaPuppy commented Apr 25, 2023

dtantsur Apr 27, 2023

dtantsur Apr 27, 2023

dtantsur Apr 27, 2023

shibaPuppy Apr 27, 2023

Rozzii commented Oct 3, 2023

Rozzii commented Oct 3, 2023

Rozzii left a comment

Rozzii commented Oct 5, 2023

Rozzii commented Oct 5, 2023

kashifest commented Oct 5, 2023

Rozzii commented Oct 5, 2023

kashifest commented Oct 5, 2023

adilGhaffarDev left a comment

lentzi90 commented Oct 5, 2023

lentzi90 commented Oct 5, 2023

kashifest commented Oct 5, 2023

kashifest commented Oct 5, 2023

kashifest commented Oct 5, 2023

metal3-io-bot commented Oct 5, 2023

✨ Add bond hash policy #708

✨ Add bond hash policy #708

Conversation

shibaPuppy commented Sep 6, 2022 • edited Loading

metal3-io-bot commented Sep 6, 2022

dtantsur left a comment

Choose a reason for hiding this comment

shibaPuppy commented Sep 7, 2022 • edited Loading

metal3-io-bot commented Apr 17, 2023

shibaPuppy commented Apr 25, 2023

dtantsur Apr 27, 2023

Choose a reason for hiding this comment

dtantsur Apr 27, 2023

Choose a reason for hiding this comment

dtantsur Apr 27, 2023

Choose a reason for hiding this comment

shibaPuppy Apr 27, 2023

Choose a reason for hiding this comment

Rozzii commented Oct 3, 2023

Rozzii commented Oct 3, 2023

Rozzii left a comment

Choose a reason for hiding this comment

Rozzii commented Oct 5, 2023

Rozzii commented Oct 5, 2023

kashifest commented Oct 5, 2023

Rozzii commented Oct 5, 2023

kashifest commented Oct 5, 2023

adilGhaffarDev left a comment

Choose a reason for hiding this comment

lentzi90 commented Oct 5, 2023

lentzi90 commented Oct 5, 2023

kashifest commented Oct 5, 2023

kashifest commented Oct 5, 2023

kashifest commented Oct 5, 2023

metal3-io-bot commented Oct 5, 2023

shibaPuppy commented Sep 6, 2022 •

edited

Loading

shibaPuppy commented Sep 7, 2022 •

edited

Loading