Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Set value of CAPM3RELEASE instead of relying on metal3-dev-env #2183

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

adilGhaffarDev
Copy link
Member

@adilGhaffarDev adilGhaffarDev commented Dec 20, 2024

What this PR does / why we need it:
Set value of CAPM3RELEASE instead of relying on metal3-dev-env

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2181

@metal3-io-bot metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 20, 2024
scripts/ci-e2e.sh Outdated Show resolved Hide resolved
scripts/ci-e2e.sh Outdated Show resolved Hide resolved
scripts/ci-e2e.sh Outdated Show resolved Hide resolved
@kashifest
Copy link
Member

/approve
/hold
PTAL @tuminoid's comments

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 20, 2024
@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 20, 2024
Signed-off-by: Muhammad Adil Ghaffar <muhammad.adil.ghaffar@est.tech>
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 20, 2024
@kashifest
Copy link
Member

/hold cancel
/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 20, 2024
@metal3-io-bot metal3-io-bot merged commit 22fc609 into metal3-io:main Dec 20, 2024
14 checks passed
@metal3-io-bot metal3-io-bot deleted the fix-2181/adil branch December 20, 2024 10:02
@metal3-io-bot metal3-io-bot added this to the CAPM3 - v1.10 milestone Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove dependency CAPM3RELEASE variable from metal3-dev-env
4 participants