Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 Update readme on test triggers on release-0.8 #1933

Merged
merged 1 commit into from
Sep 6, 2024
Merged

📖 Update readme on test triggers on release-0.8 #1933

merged 1 commit into from
Sep 6, 2024

Conversation

mquhuy
Copy link
Member

@mquhuy mquhuy commented Sep 4, 2024

This PR:

Update build status badges
Update test triggers

@metal3-io-bot metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 4, 2024
@mquhuy mquhuy force-pushed the mquhuy/update-test-triggers-release-1.8 branch from 360c5a7 to 5bacbd7 Compare September 4, 2024 07:11
@mquhuy mquhuy mentioned this pull request Sep 4, 2024
Closed
50 tasks
@mquhuy mquhuy force-pushed the mquhuy/update-test-triggers-release-1.8 branch from 5bacbd7 to f7df5f9 Compare September 4, 2024 07:20
tuminoid
tuminoid reviewed Sep 4, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@mquhuy
Update test triggers on README for release-1.8
c938ede 
Signed-off-by: Huy Mai <huy.mai@est.tech>
@mquhuy mquhuy force-pushed the mquhuy/update-test-triggers-release-1.8 branch from f7df5f9 to c938ede Compare September 4, 2024 12:54
tuminoid
tuminoid reviewed Sep 4, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 4, 2024
@mquhuy
Copy link
Member Author

mquhuy commented Sep 5, 2024

/cc @kashifest

kashifest
kashifest reviewed Sep 6, 2024
View reviewed changes
Copy link
Member

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 6, 2024
@metal3-io-bot metal3-io-bot merged commit 02f5dde into metal3-io:release-0.8 Sep 6, 2024
8 checks passed
@metal3-io-bot metal3-io-bot deleted the mquhuy/update-test-triggers-release-1.8 branch September 6, 2024 13:00
@mquhuy mquhuy mentioned this pull request Dec 5, 2024
Closed
48 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuminoid tuminoid tuminoid left review comments

@kashifest kashifest kashifest left review comments

@elfosardo elfosardo Awaiting requested review from elfosardo

@zhouhao3 zhouhao3 Awaiting requested review from zhouhao3

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mquhuy @metal3-io-bot @tuminoid @kashifest