chore: rename to serverservice and add migrate and version subcommands #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolerenee
force-pushed
the
renaming-is-fun
branch
4 times, most recently
from
25a6ff4 to
325deb0
Compare
Codecov Report
@@ Coverage Diff @@
## main #32 +/- ##
=======================================
Coverage 72.26% 72.26%
=======================================
Files 21 21
Lines 941 941
=======================================
Hits 680 680
Misses 168 168
Partials 93 93
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
The repo will need to be renamed at the time of merging this PR. |
- Rename to serverservice to respresent the fact this service only provides server information. - No longer rely on an external goose binary; this functionality is now available via the `serverservice migrate` comamnd. - Add a version subcommand to print out the current version. - Our production docker container is now a scratch container base with the alpine ca-certificates imported.
nicolerenee
force-pushed
the
renaming-is-fun
branch
from
325deb0 to
238047c
Compare
sfunkhouser
approved these changes
Aug 27, 2021
| // migrateCmd represents the migrate command | ||
| var migrateCmd = &cobra.Command{ | ||
| Use: "migrate <command> [args]", | ||
| Short: "A brief description of your command", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
serverservice migratecomamnd.make testno longer starts docker-compose for you. This is to aid when working on multiple services.