ComponentFirmwareVersion json tag to be consistent #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
json tag should be using snake_case to be consistent with the rest of server service structs.
Codecov Report
@@ Coverage Diff @@
## main #224 +/- ##
=======================================
Coverage 71.69% 71.69%
=======================================
Files 36 36
Lines 3466 3466
=======================================
Hits 2485 2485
Misses 734 734
Partials 247 247
Flags with carried forward coverage won't be shown. Click here to find out more.
|
joelrebel
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
json tag should be using snake_case to be consistent with the rest of server service structs.