Change firmware uniqueness constraint #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DoctorVin
previously approved these changes
Jun 29, 2023
diogomatsubara
force-pushed
the
change-firmware-unique-constraint
branch
from
30ad184 to
6da663f
Compare
Codecov Report
@@ Coverage Diff @@
## main #221 +/- ##
=======================================
Coverage 71.58% 71.58%
=======================================
Files 36 36
Lines 3452 3452
=======================================
Hits 2471 2471
Misses 734 734
Partials 247 247
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
@DoctorVin got some tests that I had to update. It should be good now. |
DoctorVin
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the firmware uniqueness constraint to include the filename instead of only vendor/component/version as we have cases of vendors distributing firmware for the same component but different models with the same version.