Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve OIDC config options [DEL-479] #20

Merged
merged 2 commits into from
Aug 10, 2021
Merged

Conversation

nicolerenee
Copy link
Member

No description provided.

@nicolerenee nicolerenee requested a review from a team as a code owner August 9, 2021 21:29
@codecov
Copy link

codecov bot commented Aug 9, 2021

Codecov Report

Merging #20 (e90a385) into main (da1df3e) will decrease coverage by 0.17%.
The diff coverage is 75.86%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #20      +/-   ##
==========================================
- Coverage   74.48%   74.31%   -0.18%     
==========================================
  Files          36       36              
  Lines        1372     1386      +14     
==========================================
+ Hits         1022     1030       +8     
- Misses        214      218       +4     
- Partials      136      138       +2     
Flag Coverage Δ
unittests 74.31% <75.86%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/ginjwt/jwt.go 82.50% <72.00%> (-5.56%) ⬇️
internal/hollowserver/server.go 89.13% <100.00%> (ø)
pkg/ginjwt/testtools.go 75.00% <100.00%> (+0.80%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da1df3e...e90a385. Read the comment docs.

@nicolerenee
Copy link
Member Author

I have ran this locally with our production config to ensure it works.

hollow git:(oidc_improvements)# go run main.go serve --oidc-aud="https://hollow.platformequinix.net" --oidc-issuer="https://auth.equinixmetal.com/" --oidc-jwksuri="https://auth.equinixmetal.com/.well-known/jwks.json" --oidc-roles-claim="permissions" --oidc-username-claim="https://auth.equinixmetal.com/email" --db-uri="host=localhost port=26257 user=root sslmode=disable dbname=hollow_test"
{"level":"info","ts":1628545292.801255,"caller":"cmd/serve.go:49","msg":"starting server","address":"0.0.0.0:8000"}
{"level":"info","ts":1628545308.158602,"caller":"zap@v0.0.2-0.20210226022008-5b2cf0c4d297/zap.go:121","msg":"/api/v1/servers","status":200,"method":"GET","path":"/api/v1/servers","query":"","ip":"::1","user-agent":"curl/7.64.1","time":"2021-08-09T21:41:48Z","latency":0.02980272,"jwt_subject":"waad|gkTU-RTYnZeYpruVe64q1wvbZfXF2DfVkXuY0lBBP70","jwt_user":"nhubbard@equinix.com"}

@nicolerenee nicolerenee merged commit c7a53d0 into main Aug 10, 2021
@nicolerenee nicolerenee deleted the oidc_improvements branch August 10, 2021 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants