Components attributes update #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the case where the component attribute was being added instead of being updated, which mean't the client received a duplicate key error for attempting a PUT request to update the component attributes.
…utes update Update an existing fixture component attribute as a test case - this was incorrectly adding a component attribute instead of updating it.
Codecov Report
@@ Coverage Diff @@
## main #183 +/- ##
==========================================
- Coverage 71.27% 70.89% -0.38%
==========================================
Files 35 35
Lines 3380 3412 +32
==========================================
+ Hits 2409 2419 +10
- Misses 721 740 +19
- Partials 250 253 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
JAORMX
approved these changes
Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the case where the component attribute was being added instead
of being updated, which mean't the client received a duplicate key error
for attempting a PUT request to update the component attributes.