Fix scopes for server component firmwares #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scopedRealClientTests allows tests to be written with a scoped auth token so requests to endpoints can check if the correct scope is passed.
Required auth scopes for server-component-firmwares were wrongly set to server only instead of the actual object it refers to.
Codecov Report
@@ Coverage Diff @@
## main #141 +/- ##
==========================================
+ Coverage 74.00% 74.15% +0.15%
==========================================
Files 32 32
Lines 2577 2577
==========================================
+ Hits 1907 1911 +4
+ Misses 494 491 -3
+ Partials 176 175 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
JAORMX
approved these changes
Sep 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The endpoint
/server-component-firmwaresis incorrectly requestingserverscopes instead ofserver-component-firmwares. This PR corrects the scopes and add an additionalscopedRealClientTeststest function to help test scoped requests.