migrations: Add unique db constraint for firmware #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enforce component_firmware_version table to have unique values on columns vendor, model and version.
Codecov Report
@@ Coverage Diff @@
## main #131 +/- ##
==========================================
+ Coverage 74.00% 74.15% +0.15%
==========================================
Files 32 32
Lines 2577 2577
==========================================
+ Hits 1907 1911 +4
+ Misses 494 491 -3
+ Partials 176 175 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
nicolerenee
requested changes
Aug 11, 2022
ComponentFirmwareVersion has a db constraint for unique values of vendor/model/version. Test demonstrates that we raise an error in case an attempt is made to create a new record with the duplicated values.
Thanks for the review @nicolerenee, I added a test case in 8f0b0de. Let me know what you think. |
nicolerenee
approved these changes
Aug 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enforce component_firmware_version table to have unique values on columns
vendor, model and version.
Also renamed migration
00010_server_components_idx.sqlto use consistent numbering scheme.