Add pagination support to ComponentFirmwareVersion (#227)

metal-toolbox · Aug 16, 2023 · 84744ff · 84744ff
1 parent accfa6f
commit 84744ff
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 5 deletions.
diff --git a/pkg/api/v1/firmware_list_params.go b/pkg/api/v1/firmware_list_params.go
@@ -11,11 +11,12 @@ import (
 
 // ComponentFirmwareVersionListParams allows you to filter the results
 type ComponentFirmwareVersionListParams struct {
-	Vendor   string   `form:"vendor"`
-	Model    []string `form:"model"`
-	Version  string   `form:"version"`
-	Filename string   `form:"filename"`
-	Checksum string   `form:"checksum"`
+	Vendor     string   `form:"vendor"`
+	Model      []string `form:"model"`
+	Version    string   `form:"version"`
+	Filename   string   `form:"filename"`
+	Checksum   string   `form:"checksum"`
+	Pagination *PaginationParams
 }
 
 func (p *ComponentFirmwareVersionListParams) setQuery(q url.Values) {
@@ -44,6 +45,8 @@ func (p *ComponentFirmwareVersionListParams) setQuery(q url.Values) {
 	if p.Checksum != "" {
 		q.Set("checksum", p.Checksum)
 	}
+
+	p.Pagination.setQuery(q)
 }
 
 // queryMods converts the list params into sql conditions that can be added to sql queries

diff --git a/pkg/api/v1/router_firmware_test.go b/pkg/api/v1/router_firmware_test.go
@@ -98,6 +98,16 @@ func TestIntegrationFirmwareList(t *testing.T) {
 			false,
 			"",
 		},
+		{
+			"limit results",
+			&serverservice.ComponentFirmwareVersionListParams{
+				Vendor:     "Dell",
+				Pagination: &serverservice.PaginationParams{Limit: 1},
+			},
+			[]string{dbtools.FixtureDellR640BIOS.ID},
+			false,
+			"",
+		},
 	}
 
 	for _, tt := range testCases {