db/migrations: adds constraint on firmware sets to restrict fimrmware…

… deletion

When a firmware row is referenced by a firmware set, restrict deletion of the firmware row,
This ensures referential integrity in firmware sets.

Updates test for constraint check.

db/migrations/00020_firmware_set_update_constraint.sql

@@ -0,0 +1,16 @@
+-- +goose NO TRANSACTION
+-- +goose Up
+-- +goose StatementBegin
+
+ALTER TABLE component_firmware_set_map DROP CONSTRAINT fk_firmware_id_ref_component_firmware_version;
+ALTER TABLE component_firmware_set_map ADD CONSTRAINT fk_firmware_id_ref_component_firmware_version FOREIGN KEY (firmware_id) REFERENCES component_firmware_version(id) ON DELETE RESTRICT;
+
+-- +goose StatementEnd
+
+-- +goose Down
+-- +goose StatementBegin
+
+ALTER TABLE component_firmware_set_map DROP CONSTRAINT fk_firmware_id_ref_component_firmware_version;
+ALTER TABLE component_firmware_set_map ADD CONSTRAINT fk_firmware_id_ref_component_firmware_version FOREIGN KEY (firmware_id) REFERENCES component_firmware_version(id) ON DELETE CASCADE;
+
+-- +goose StatementEnd

pkg/api/v1/router_firmware_test.go

@@ -271,10 +271,13 @@ func TestIntegrationServerComponentFirmwareDelete(t *testing.T) {
 
 	realClientTests(t, func(ctx context.Context, authToken string, respCode int, expectError bool) error {
 		s.Client.SetToken(authToken)
-		_, err := s.Client.DeleteServerComponentFirmware(ctx, serverservice.ComponentFirmwareVersion{UUID: uuid.MustParse(dbtools.FixtureDellR640BMC.ID)})
+		_, err := s.Client.DeleteServerComponentFirmware(ctx, serverservice.ComponentFirmwareVersion{UUID: uuid.MustParse(dbtools.FixtureDellR640CPLD.ID)})
 
 		return err
 	})
+
+	_, err := s.Client.DeleteServerComponentFirmware(context.TODO(), serverservice.ComponentFirmwareVersion{UUID: uuid.MustParse(dbtools.FixtureDellR640BMC.ID)})
+	assert.Contains(t, err.Error(), "violates foreign key constraint \"fk_firmware_id_ref_component_firmware_version\"")
 }
 
 func TestIntegrationServerComponentFirmwareUpdate(t *testing.T) {