Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't removeAll current firmware directory #244

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ofaurax
Copy link
Contributor

@ofaurax ofaurax commented Jan 9, 2025

When running the flasher on a local file, its whole dir is emptied by RemoveAll.

This is to ensure cleanup of firmware download dir, but will also remove all files beside the firmware on local test.
We should handle this at another level.

This PR removes the RemoveAll on non-tmp directories, to be safe.

@DoctorVin
Copy link
Collaborator

Does Flasher actually create a temporary directory? I'm concerned that if Flasher no longer cleans up, we may accumulate junk where we don't expect it.

@ofaurax
Copy link
Contributor Author

ofaurax commented Jan 10, 2025

@DoctorVin we won't accumulate junk, because the functions that are downloading the data are cleaning the created (temporary) dir.

We have functions that download stuff in a temporary dir, then clean it, and we have functions that upload files and also clean the dir in which there is the uploaded file. Only downloaded stuff should be cleaned IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants