outofband: power off the host if the provider indicates its required

The powerOff would be skipped since the provider install parameter was
not being considered

internal/model/action.go

@@ -51,6 +51,10 @@ type Action struct {
 	// HostPowerCycled is set when the host has been power cycled for the action.
 	HostPowerCycled bool `json:"host_power_cycled"`
 
+	// HostPowerOffPreInstall is set when the firmware install provider indicates
+	// the host must be powered off before proceeding with the install step.
+	HostPowerOffPreInstall bool `json:"host_power_off_pre_install"`
+
 	// First is set to true when its the first action being executed
 	First bool `json:"first"`
 

internal/outofband/action_handlers.go

@@ -785,6 +785,11 @@ func (h *handler) powerCycleServer(ctx context.Context) error {
 }
 
 func (h *handler) conditionalPowerOffDevice(_ context.Context) (bool, error) {
+	// The install provider indicated the host must be powered off
+	if h.action.HostPowerOffPreInstall {
+		return true, nil
+	}
+
 	// proceed to power off the device if this is the final action
 	if !h.action.Last {
 		return false, nil

internal/outofband/actions.go

@@ -87,6 +87,7 @@ func (o *ActionHandler) ComposeAction(ctx context.Context, actionCtx *runner.Act
 		BMCResetPreInstall:       bmcResetBeforeInstall,
 		BMCResetPostInstall:      bmcResetPostInstall,
 		BMCResetOnInstallFailure: bmcResetOnInstallFailure,
+		HostPowerOffPreInstall:   hostPowerOffRequired(required),
 		ForceInstall:             actionCtx.Task.Parameters.ForceInstall,
 		Steps:                    steps,
 		First:                    actionCtx.First,

internal/outofband/actions_test.go

@@ -42,6 +42,7 @@ func TestComposeAction(t *testing.T) {
 		expectForceInstall             bool
 		expectBMCResetPostInstall      bool
 		expectBMCResetOnInstallFailure bool
+		expectHostPowerOffPreInstall   bool
 		expectErrContains              string
 	}{
 		{
@@ -94,6 +95,23 @@ func TestComposeAction(t *testing.T) {
 				)
 			},
 		},
+		{
+			name:                         "test host power off pre-install",
+			expectHostPowerOffPreInstall: true,
+			mockSetup: func(actionCtx *runner.ActionHandlerContext, m *device.MockQueryor) {
+				actionCtx.First = true
+
+				actionCtx.DeviceQueryor = m
+				m.On("FirmwareInstallSteps", mock.Anything, "drive").Once().Return(
+					[]bconsts.FirmwareInstallStep{
+						bconsts.FirmwareInstallStepPowerOffHost,
+						bconsts.FirmwareInstallStepUploadInitiateInstall,
+						bconsts.FirmwareInstallStepInstallStatus,
+					},
+					nil,
+				)
+			},
+		},
 		{
 			name:                           "test bmc reset on install failure",
 			expectBMCResetOnInstallFailure: true,
@@ -179,6 +197,13 @@ func TestComposeAction(t *testing.T) {
 				assert.False(t, got.BMCResetOnInstallFailure)
 			}
 
+			// host power off required before install
+			if tc.expectHostPowerOffPreInstall {
+				assert.True(t, got.HostPowerOffPreInstall)
+			} else {
+				assert.False(t, got.HostPowerOffPreInstall)
+			}
+
 			// expect atleast 5 or more steps
 			assert.GreaterOrEqual(t, len(got.Steps), 5)
 		})

internal/outofband/bmc_helpers.go

@@ -28,6 +28,11 @@ import (
 	"github.com/sirupsen/logrus"
 )
 
+// NOTE: the constants.FirmwareInstallStep type will be moved to the FirmwareInstallProperties struct type which will make this easier
+func hostPowerOffRequired(steps []constants.FirmwareInstallStep) bool {
+	return slices.Contains(steps, constants.FirmwareInstallStepPowerOffHost)
+}
+
 // NOTE: the constants.FirmwareInstallStep type will be moved to the FirmwareInstallProperties struct type which will make this easier
 func bmcResetParams(steps []constants.FirmwareInstallStep) (bmcResetOnInstallFailure, bmcResetPostInstall bool) {
 	for _, step := range steps {