worker; clearer atomic decrement for dispatched routines

add note to separate message pulling and processing contexts
metal-toolbox · May 4, 2023 · 5880908 · 5880908
1 parent 5649a62
commit 5880908
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/internal/worker/worker.go b/internal/worker/worker.go
@@ -127,6 +127,7 @@ Loop:
 }
 
 func (o *Worker) processEvents(ctx context.Context) {
+	// XXX: consider having a separate context for message retrieval
 	msgs, err := o.stream.PullMsg(ctx, 1)
 	if err != nil {
 		o.logger.WithFields(
@@ -148,7 +149,7 @@ func (o *Worker) processEvents(ctx context.Context) {
 			defer o.syncWG.Done()
 
 			atomic.AddInt32(&o.dispatched, 1)
-			defer atomic.AddInt32(&o.dispatched, ^int32(0))
+			defer atomic.AddInt32(&o.dispatched, -1)
 
 			o.processEvent(ctx, msg)
 		}(msg)