FS-1053 Fix firmware record updates for existing firmware #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coffeefreak101
requested review from
diogomatsubara,
joelrebel and
DoctorVin
diogomatsubara
previously approved these changes
Dec 18, 2023
There was a problem hiding this comment.
These changes look great! It's really good to have another set of eyes on this codebase and improve it as you did. Thank you @coffeefreak101 ! I made one comment about changing the equinix package to github. It'd be nice to also deal with all the lint warnings. Other than that, LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The firmware-syncer is not updating records in serverservice for firmware with existing files in the S3 bucket.
This change refactors the vendor code to reduce some code duplication and fix the issue in one place instead of several.
Also refactored some of the code to make it more testable, and added some mocks.