Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Publish() to set consistent artifacts url #136

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Update Publish() to set consistent artifacts url #136

merged 1 commit into from
Nov 10, 2023

Conversation

diogomatsubara
Copy link
Contributor

Use artifacts URL + vendors.DstPath() to consistently set the artifacts URL on a ComponentFirmwareVersion object before publishing to server service.

@diogomatsubara
Update Publish() to set consistent artifacts url
5534fbd 
Use artifacts URL + vendors.DstPath() to consistently set the
artifacts URL on a ComponentFirmwareVersion object before publishing to
server service.
joelrebel
joelrebel approved these changes Nov 10, 2023
View reviewed changes
Copy link
Member

@joelrebel joelrebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for the fixes

joelrebel
joelrebel approved these changes Nov 10, 2023
View reviewed changes
Copy link
Member

@joelrebel joelrebel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for the fixes
edit: (thank vscode for the duplicate comment)

@diogomatsubara diogomatsubara merged commit 20515a7 into main Nov 10, 2023
@diogomatsubara diogomatsubara deleted the fs-994-incorret-repository-url branch November 10, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelrebel joelrebel joelrebel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@diogomatsubara @joelrebel