Add make targets to build devel image of syncer #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This image can be used with the metal-toolbox/sandbox
joelrebel
previously approved these changes
Nov 9, 2023
Makefile
Outdated
| --label org.label-schema.vcs-url=$(REPO) | ||
|
|
||
| ## Build devel docker image | ||
| build-image-devel: build-image |
There was a problem hiding this comment.
can you rename this to push-image-devel similar to here https://github.com/metal-toolbox/flasher/blob/7b55d2571eabec60a9b6a7b174fa55cb74edb9ae/Makefile#L60
There was a problem hiding this comment.
Fixed in 95f5b33
Align better with metal-toolbox/flasher
joelrebel
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This image can be used with the metal-toolbox/sandbox