Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle env var and app config from single location #134

Merged
merged 3 commits into from
Nov 10, 2023

Conversation

diogomatsubara
Copy link
Contributor

Update configuration handling to align with the rest of tooling in the
metal-toolbox. These changes moves the environment variable handling to
be centralized in the config package rather than on per-vendor basis.

Update configuration handling to align with the rest of tooling in the
metal-toolbox. These changes moves the environment variable handling to
be centralized in the config package rather than on per-vendor basis.
joelrebel
joelrebel previously approved these changes Nov 7, 2023
Copy link
Member

@joelrebel joelrebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look okay to me, my only suggestion is to include some sample configuration files.

@diogomatsubara
Copy link
Contributor Author

@joelrebel I added an example config file in 6c208ac

@diogomatsubara diogomatsubara merged commit 2f3501f into main Nov 10, 2023
@diogomatsubara diogomatsubara deleted the fs-815-env-var branch November 10, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants