Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Factor out service exposals into default variables. #112

Merged
merged 3 commits into from
Jul 21, 2022
Merged

Factor out service exposals into default variables. #112

merged 3 commits into from
Jul 21, 2022

Conversation

Gerrit91
Copy link
Contributor

Otherwise it cannot be nicely parametrized.

@Gerrit91 Gerrit91 marked this pull request as ready for review July 21, 2022 12:21
@Gerrit91 Gerrit91 requested a review from a team as a code owner July 21, 2022 12:21
GrigoriyMikhalkin
GrigoriyMikhalkin approved these changes Jul 21, 2022
View reviewed changes
Copy link
Contributor

@GrigoriyMikhalkin GrigoriyMikhalkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Gerrit91 Gerrit91 merged commit bcbb8ee into master Jul 21, 2022
@Gerrit91 Gerrit91 deleted the ingress-exposals branch July 21, 2022 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrigoriyMikhalkin GrigoriyMikhalkin GrigoriyMikhalkin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gerrit91 @GrigoriyMikhalkin