Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dualstack Network Support #549

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open

Dualstack Network Support #549

wants to merge 23 commits into from

Conversation

majst01
Copy link
Contributor

@majst01 majst01 commented Jul 17, 2024 •
edited
Loading

Actions Required

The ChildPrefixLength property was removed from the Partition Entity. Every TenantSupernetwork must now be configured with ChildPrefixLength accordingly.
This is done during startup in the database migration step and set to the same value as in the `Partition`.

It is required to add a defaultchildprefixlength property to the tenant super network in you configuration because otherwise the initial network creation will fail:
Sample:
  defaultchildprefixlength:
    IPv4: 22

Depends on:

replaces #544

TODO:

  • add possibility to create machines in different networks like internet and tenant-network, but only from tenant-network IPs from both AF are acquired, but only ipv4 is possible from internet even if dualstack

@majst01 majst01 force-pushed the dualstack-support branch 4 times, most recently from 5919c8f to 0c53831 Compare July 23, 2024 07:47
@Gerrit91 Gerrit91 mentioned this pull request Jul 23, 2024
Draft
8 tasks
@majst01 majst01 force-pushed the dualstack-support branch 7 times, most recently from d49d2c0 to b65c835 Compare July 25, 2024 09:50
@majst01 majst01 force-pushed the dualstack-support branch 3 times, most recently from 23a3d1e to 89096c0 Compare August 2, 2024 12:40
@majst01 majst01 mentioned this pull request Aug 2, 2024
Merged
@majst01 majst01 force-pushed the dualstack-support branch 2 times, most recently from a3571a2 to d9667d3 Compare August 5, 2024 07:13
@majst01 majst01 force-pushed the dualstack-support branch 2 times, most recently from b565e1b to d8d9a9c Compare August 13, 2024 16:19
@majst01 majst01 marked this pull request as ready for review August 13, 2024 16:19
@majst01 majst01 requested a review from a team as a code owner August 13, 2024 16:19
@majst01 majst01 requested a review from Gerrit91 August 13, 2024 16:19
@majst01 majst01 force-pushed the dualstack-support branch 3 times, most recently from f408888 to 20becc4 Compare August 14, 2024 07:47
majst01
majst01 commented Sep 5, 2024
View reviewed changes
cmd/metal-api/internal/metal/machine.go
@@ -235,9 +235,6 @@ func (r IngressRule) Validate() error {
if err := validateCIDRs(r.From); err != nil {
return err
}
if err := validateCIDRs(slices.Concat(r.From, r.To)); err != nil {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this was ok to delete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gerrit91 Gerrit91 Awaiting requested review from Gerrit91 Gerrit91 is a code owner automatically assigned from metal-stack/metal-api-maintainers

At least 1 approving review is required to merge this pull request.

Assignees

@majst01 majst01

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@majst01