Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend refactor: typescript added, updated packages, directory structure and functional components #55

Merged
merged 15 commits into from
Jun 9, 2024

Conversation

lakshz
Copy link
Contributor

@lakshz lakshz commented Nov 24, 2023

typescript added, updated packages, improved directory structure, and converted all class-based components to functional components

Completes task 1, 2 and 3 of issue #28

frontend/src/components/CustomTable/CustomTable.js Outdated Show resolved Hide resolved
frontend/src/components/EmptyRoomTable/EmptyRoomsTable.js Outdated Show resolved Hide resolved
frontend/src/components/TwoSlotDisplay.js Outdated Show resolved Hide resolved
frontend/src/constants/constants.js Outdated Show resolved Hide resolved
@lakshz lakshz changed the title Frontend refactor: better folder structure and functional components Frontend refactor: typescript added, updated packages, directory structure and functional components Nov 26, 2023
@lakshz lakshz requested a review from chirag-ghosh November 26, 2023 21:58
Copy link
Member

@chirag-ghosh chirag-ghosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not use ChillPlace for variable names. Using Classroom will be better

frontend/package.json Outdated Show resolved Hide resolved
frontend/src/components/TwoSlotDisplay.tsx Outdated Show resolved Hide resolved
frontend/src/index.tsx Outdated Show resolved Hide resolved
frontend/src/registerServiceWorker.ts Show resolved Hide resolved
frontend/src/util/utilities.ts Outdated Show resolved Hide resolved
frontend/src/util/utilities.ts Outdated Show resolved Hide resolved
frontend/src/lib/types.ts Show resolved Hide resolved
frontend/src/lib/types.ts Outdated Show resolved Hide resolved
frontend/src/lib/types.ts Outdated Show resolved Hide resolved
@lakshz lakshz requested a review from chirag-ghosh November 30, 2023 09:01
Copy link
Member

@chirag-ghosh chirag-ghosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@proffapt
Copy link
Member

proffapt commented Jun 8, 2024

@chirag-ghosh what about this?

@chirag-ghosh
Copy link
Member

chirag-ghosh commented Jun 8, 2024 via email

@proffapt
Copy link
Member

proffapt commented Jun 9, 2024

@shikharish ^^

@shikharish
Copy link
Member

Yes, I ran it locally, there was this issue
image

Signed-off-by: Chirag Ghosh <cghosh828049@gmail.com>
Signed-off-by: Chirag Ghosh <cghosh828049@gmail.com>
Signed-off-by: Chirag Ghosh <cghosh828049@gmail.com>
@chirag-ghosh
Copy link
Member

Fixed it now. Although need to fix the conflicts too

Signed-off-by: Chirag Ghosh <cghosh828049@gmail.com>
Signed-off-by: Chirag Ghosh <cghosh828049@gmail.com>
Signed-off-by: Chirag Ghosh <cghosh828049@gmail.com>
Signed-off-by: Chirag Ghosh <cghosh828049@gmail.com>
@chirag-ghosh chirag-ghosh requested a review from shikharish June 9, 2024 15:15
Copy link
Member

@shikharish shikharish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Chirag Ghosh <cghosh828049@gmail.com>
@shikharish shikharish merged commit d426ab7 into metakgp:master Jun 9, 2024
1 check passed
@proffapt proffapt mentioned this pull request Jun 10, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants