-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Frontend refactor: typescript added, updated packages, directory structure and functional components #55
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's not use ChillPlace
for variable names. Using Classroom
will be better
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@chirag-ghosh what about this? |
Have to check if the frontend works. iirc Shikhar had some problems making
it work
…On Sun, 9 Jun 2024 at 00:26, Arpit Bhardwaj ***@***.***> wrote:
@chirag-ghosh <https://github.com/chirag-ghosh> what about this?
—
Reply to this email directly, view it on GitHub
<#55 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ASAU24SRB32OG4OKLWXT4VLZGNHV7AVCNFSM6AAAAABJAGLIXKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJWGE2DAMRUGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@shikharish ^^ |
Signed-off-by: Chirag Ghosh <cghosh828049@gmail.com>
Signed-off-by: Chirag Ghosh <cghosh828049@gmail.com>
Signed-off-by: Chirag Ghosh <cghosh828049@gmail.com>
Fixed it now. Although need to fix the conflicts too |
Signed-off-by: Chirag Ghosh <cghosh828049@gmail.com>
Signed-off-by: Chirag Ghosh <cghosh828049@gmail.com>
Signed-off-by: Chirag Ghosh <cghosh828049@gmail.com>
Signed-off-by: Chirag Ghosh <cghosh828049@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Chirag Ghosh <cghosh828049@gmail.com>
typescript added, updated packages, improved directory structure, and converted all class-based components to functional components
Completes task 1, 2 and 3 of issue #28