Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed first year scraper; Improved directory structure. #38

Merged
merged 14 commits into from
Sep 11, 2023
Merged

Fixed first year scraper; Improved directory structure. #38

merged 14 commits into from
Sep 11, 2023

Conversation

shikharish
Copy link
Member

No description provided.

@chirag-ghosh chirag-ghosh mentioned this pull request Sep 5, 2023
12 tasks
fix: deleted irrelevant json files
fix: removed redundant commented code
fix: renamed chillzone.py > update_data.py
added relevant comments
added requirements.txt
fixed minor bug
Copy link
Member

@harshkhandeparkar harshkhandeparkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you specify a range in the requirements.txt? Or does it require a very specific versions of the packages?

@shikharish
Copy link
Member Author

Done.
Also, where should I specify that it (the first-year-scraper) requires python<=3.8 ?

update_data.py Outdated Show resolved Hide resolved
requirements.txt Outdated Show resolved Hide resolved
@chirag-ghosh
Copy link
Member

Done. Also, where should I specify that it (the first-year-scraper) requires python<=3.8 ?

This has to be done in README

bash script now used instead of python script to update data
Copy link
Member

@harshkhandeparkar harshkhandeparkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully the final review.

update_data.sh Outdated Show resolved Hide resolved
first-year-scraper/requirements.txt Outdated Show resolved Hide resolved
@chirag-ghosh chirag-ghosh merged commit 976b51a into metakgp:master Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants