Introduce @MetafixToDo annotation to mark tests as disabled.
#158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to `org.junit.jupiter.api.Disabled`, but ensures that fixed tests don't stay disabled. Failing tests marked as "to do" will be reported as *skipped*; passing tests marked as "to do" will be reported as *failed*.
fsteeg
approved these changes
Feb 17, 2022
|
Haha, what a coincidence :) |
blackwinter
added a commit
that referenced
this pull request
Feb 21, 2022
Set `org.metafacture.metafix.disableToDo=true` to mimic previous `@Disabled` behaviour.
|
Since it's getting a bit unwieldy in day-to-day work after all, I've added (f4a7523) a system property |
blackwinter
added a commit
that referenced
this pull request
Feb 22, 2022
blackwinter
added a commit
that referenced
this pull request
Mar 3, 2022
Similar to previous `disabled.txt`, but ensures that fixed integration tests don't stay disabled. Failing tests marked as "to do" will be reported as *skipped*; passing tests marked as "to do" will be reported as *failed*. Set environment variable `METAFIX_DISABLE_TO_DO=true` (or system property `org.metafacture.metafix.disableToDo=true` when run via Gradle) to mimic previous `disabled.txt` behaviour. Analogous to `@MetafixToDo` annotation in unit tests (see #158 and f4a7523).
blackwinter
added a commit
that referenced
this pull request
Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we're keeping quite a few disabled tests in stock that indicate pending work (which is a good thing), it's not always clear (to me, at least) when any of those tests might be resolved due to (seemingly unrelated) fixes. So I'd like to propose a new
@MetafixToDoannotation instead of the current@Disabledannotation, which takes care of reminding us of no longer failing tests: Failing tests marked as "to do" will be reported as skipped (just as before¹); passing tests marked as "to do" will be reported as failed (so we know we can remove the annotation).¹ Except not quite: One problem with the proposed approach is that the log messages of still failing tests somewhat clutter the test output. We could reduce the log level for tests to
ERRORas a remedy. OTOH, it's not entirely useless to see those messages, because sometimes disabled tests fail for the wrong reason ;) (seeMetafixSelectorTest.reject()for instance).