Encode top-level MARC record leader as proper XML element instead of control field. #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…control field. The XML decoder (not knowing anything about MARC) emits the leader element as a top-level literal. This is in contrast to the MARC21 decoder which wraps it in an entity. The latter seems to be a historical artifact, originating from the removal of the `splitLeader` setting in `Marc21Decoder` (6d04d69) and the subsequent introduction of the `emitLeaderAsWhole` setting (76eb9fd). Fixes #336.
dr0i
approved these changes
Oct 4, 2021
|
Thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The XML decoder (not knowing anything about MARC) emits the leader element as a top-level literal. This is in contrast to the MARC21 decoder which wraps it in an entity.
The latter seems to be a historical artifact, originating from the removal of the
splitLeadersetting inMarc21Decoder(6d04d69) and the subsequent introduction of theemitLeaderAsWholesetting (76eb9fd).Fixes #336.