YIM 2024 #3105
Merged
YIM 2024 #3105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
will be used for cover art composites, putting top albums as a placeholder
still needs some tweaks, but setting everything in place
They're customized by season!
+ fix lazy loading
Having a build error after the minor update. Don't have time or headspace to fix now, and update is not required. Do the de-volution !
sasving the SVG as PNG does not support blend modes, so we do some modifications to simplify our lives
Add Genre Graph for YIM 2024
They get just too big
they get toobig otherwise and you lose some of the mosaic effect from not seeing the whole image at once. Users can click the images to open them full size in their browser anyway to get a closer look, let the browser handle zooming and panning.
I was seeing a weird bug in the MacOS email client ("Mail" *rolls eyes*) with image centering/size, and I think this should fix it
Left the simpler `max-width: 600px` declaration as a fallback just in case because I know HTML clients' CSS support leaves to be desired.
Otherwise when saving or sharing the image the font is not rendered and the default one is used
Fix some issue with rendering the SVGs to canvas because of nested title elements. Also fixes LB-1675 where links in the SVG are relative and point to non-existing pages on api.LB that should point to LB. Even better would be to detect beta-api.LB and test-api.LB and point to beta.LB and test.LB respectively.
Otherwise CanVG freaks out and placement of images is all wrong or they are not appearing at all.
Otherwise it darkens all the other colors
|
Hello @amCap1712! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2025-01-01 07:35:05 UTC |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.