Make develop.sh and test.sh compatible with compose v2 #2184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The command to execute docker compose in v2 is `docker compose` as opposed to `docker-compose` in v1. I recently upgraded versions on my local machine and faced errors while trying to execute the scripts. Since, no else has complained so far they are likely using v1. Therefore, updating the scripts to check the version of docker compose installed and invoke the appropriate command for compatibility with both versions. Note that there are some differences between the two commands but AFAIU those are not relevant to our uses.
|
I tested locally where I have v2 and on wolf where we have v1 and the scripts work in both cases. |
amCap1712
added a commit
to metabrainz/critiquebrainz
that referenced
this pull request
Nov 29, 2023
amCap1712
added a commit
to metabrainz/critiquebrainz
that referenced
this pull request
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The command to execute docker compose in v2 is
docker composeas opposed todocker-composein v1. I recently upgraded versions on my local machine and faced errors while trying to execute the scripts. Since, no else has complained so far they are likely using v1. Therefore, updating the scripts to check the version of docker compose installed and invoke the appropriate command for compatibility with both versions.Note that there are some differences between the two commands but AFAIU those are not relevant to our uses.