Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change socket to http in uwsgi.ini #502

Merged
merged 3 commits into from
Nov 21, 2023
Merged

Change socket to http in uwsgi.ini #502

merged 3 commits into from
Nov 21, 2023

Conversation

MonkeyDo
Copy link
Member

@MonkeyDo MonkeyDo commented Nov 2, 2023

We are trying to resolve issues with uWSGI running in the CB docker containers, which fail with the error bind(): Address already in use [core/socket.c line 769]
See this discussion or some background: https://chatlogs.metabrainz.org/libera/metabrainz/2023-11-02/?msg=5243055&page=2

This mimics how we configure the artwork redirect container: https://github.com/metabrainz/artwork-redirect/blob/c632ecfda1c5d5037e20a341f992b35ea7cc5ab8/docker/prod/uwsgi.ini#L3

We are trying to resolve issues with uWSGI running in the CB docker containers, which fail with the error `bind(): Address already in use [core/socket.c line 769]`
See this discussion or some background: https://chatlogs.metabrainz.org/libera/metabrainz/2023-11-02/?msg=5243055&page=2
@MonkeyDo MonkeyDo requested a review from zas November 2, 2023 11:34
@MonkeyDo
Copy link
Member Author

MonkeyDo commented Nov 2, 2023

I am building a docker image from this branch so i can deploy it to the beta CB container.
If everything is working fine and in the coming days/weeks the container is still stable while the untouched prod container fails, then we can merge this PR

Copy link

github-actions bot commented Nov 2, 2023

Test Results

201 tests  ±0   201 ✔️ ±0   11m 59s ⏱️ -41s
    1 suites ±0       0 💤 ±0 
    1 files   ±0       0 ±0 

Results for commit 23574af. ± Comparison against base commit 1ff9d6e.

Copy link

@zas zas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually this doesn't work without changes to gateways config.
Plus it might not be the actual issue.

amCap1712 and others added 2 commits November 3, 2023 00:55
The default uwsgi config doesn't play well with consul-template. Add
exit-on-reload for clean shutdown. The rest of changes help make startup
more robust.
@amCap1712 amCap1712 merged commit f8f70b2 into master Nov 21, 2023
1 check passed
@amCap1712 amCap1712 deleted the uwsgi-config branch November 21, 2023 19:40
@MonkeyDo
Copy link
Member Author

Thanks @amCap1712 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants