Fix single quotes #490
Merged
Fix single quotes #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Curved quotation marks were used instead of straight ones as Python string delimiters, whereas they should be used inside strings only. That broke returning the “About” page. This patch fixes delimiters and escaped occurrences.
Replace straight single quotes in strings where appropriate.
Replace straight single quotes in strings where appropriate.
This comment has been minimized.
This comment has been minimized.
|
Manually tested in |
Unit Test Results 1 files ±0 1 suites ±0 9m 11s ⏱️ ±0s For more details on these failures, see this check. Results for commit 3c89596. ± Comparison against base commit 3c89596. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
An ISE (500) was returned instead of the page “About” with the pull requests #488 and #489 not released yet.
Solution
‘’that were used instead of straight one'as string delimiterExtra
'that were used instead of typographic apostrophe’in strings'that were used instead of curved quotation marks“”in strings