Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade webpack to v5 #477

Merged
merged 2 commits into from
Oct 24, 2022
Merged

Upgrade webpack to v5 #477

merged 2 commits into from
Oct 24, 2022

Conversation

alastair
Copy link
Collaborator

No description provided.

MonkeyDo
MonkeyDo approved these changes Oct 24, 2022
View reviewed changes
Copy link
Member

@MonkeyDo MonkeyDo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stamp of approval.
P.S.: I haven't run this locally, but if it builds the JS and CSS successfully (as reported by alastair) it's 👍

@github-actions

This comment has been minimized.

Sign in to view
@alastair alastair merged commit a868a4a into master Oct 24, 2022
@alastair alastair deleted the webpack-upgrade branch October 24, 2022 16:39
@github-actions
Copy link

Unit Test Results

    1 files  ±0      1 suites  ±0   1m 42s ⏱️ ±0s
198 tests ±0  198 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit a868a4a. ± Comparison against base commit a868a4a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MonkeyDo MonkeyDo MonkeyDo approved these changes

@amCap1712 amCap1712 Awaiting requested review from amCap1712

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alastair @MonkeyDo