Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CB-439 (I): Only include text reviews on front page recent reviews #462

Merged
merged 1 commit into from
Aug 30, 2022

Conversation

alastair
Copy link
Collaborator

CB-439

Reviews can be either text, a rating, or both.
In my experience, looking at the recent reviews list on the homepage is annoying if you click through to some new ones and see that they're only ratings.
In order to make the list of reviews more useful, only show ones that have actual text reviews.

@alastair alastair requested a review from amCap1712 August 24, 2022 11:40
@github-actions

This comment has been minimized.

Copy link
Member

@amCap1712 amCap1712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@alastair alastair merged commit 6a873f5 into master Aug 30, 2022
@alastair alastair deleted the recent-reviews-text-only branch August 30, 2022 15:16
@github-actions
Copy link

Unit Test Results

    1 files  ±0      1 suites  ±0   2m 4s ⏱️ ±0s
194 tests ±0  194 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 6a873f5. ± Comparison against base commit 6a873f5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants