CB-438: add rel=nofollow to links in reviews #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because we allow users to write links in reviews and comments, we should mark them as rel=nofollow so that spam links don't negatively affect CB's search ranking
alastair
changed the title
This comment has been minimized.
This comment has been minimized.
amCap1712
approved these changes
Aug 26, 2022
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because we allow users to write links in reviews and comments, we should mark them as rel=nofollow so that any spam links that might come through don't negatively affect CB's search ranking
I didn't include noreferrer (or noopener) in this case, I'm not sure if it's strictly necessary as well, any thoughts @amCap1712?