CB-444: API error messages are music-specific #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alastair
reviewed
Aug 16, 2022
Without this check it would be possible to create a review in draft mode, or have a review hidden and then submit one again. This test would pass, but then an sql server error would be raised due to duplicate key when trying to save the review.
These extensions are now built into jinja and don't need to be specified separately
We share some code and variables between the website and webservice which is translated with lazy_gettext. If the babel extension is not installed in the flask app, the evaluation of this variable causes an unhandled exception in babel. In order to prevent this exception, configure babel with a domain which is different to the default `messages` domain used in the website. This will result in no translations being found, and the strings being passed through to the WS in english.
alastair
approved these changes
Aug 26, 2022
|
@anshg1214 I believe I fixed the babel error that occurs when trying to render a |
|
It is working now. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CB-444