Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow CB to review Literary Works #452

Merged
merged 38 commits into from
Aug 16, 2022
Merged

Allow CB to review Literary Works #452

merged 38 commits into from
Aug 16, 2022

Conversation

anshg1214
Copy link
Member

@anshg1214 anshg1214 commented Jul 29, 2022 •
edited
Loading

This PR allows users to browse and review BookBrainz Literary Works.

NOTE: This PR needs to be merged first.

@anshg1214 anshg1214 mentioned this pull request Jul 29, 2022
Merged
alastair
alastair requested changes Aug 5, 2022
View reviewed changes
Copy link
Collaborator

@alastair alastair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, and works for me locally!
Just a few small recommendations for code cleanups. Make sure you also apply these to the other open PRs too

critiquebrainz/db/review.py Show resolved Hide resolved
critiquebrainz/frontend/external/bookbrainz_db/literary_work.py Outdated Show resolved Hide resolved
critiquebrainz/frontend/external/bookbrainz_db/literary_work.py Outdated Show resolved Hide resolved
critiquebrainz/frontend/external/bookbrainz_db/literary_work.py Outdated Show resolved Hide resolved
critiquebrainz/db/review.py Outdated Show resolved Hide resolved
critiquebrainz/db/review.py Show resolved Hide resolved
critiquebrainz/frontend/views/bb_literary_work.py Outdated Show resolved Hide resolved
critiquebrainz/frontend/external/bookbrainz.py Outdated Show resolved Hide resolved
@anshg1214 anshg1214 requested a review from alastair August 10, 2022 07:14
alastair
alastair approved these changes Aug 16, 2022
View reviewed changes
Copy link
Collaborator

@alastair alastair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@alastair alastair merged commit 19a49a4 into metabrainz:master Aug 16, 2022
@github-actions
Copy link

Unit Test Results

    1 files  ±0      1 suites  ±0   1m 43s ⏱️ ±0s
190 tests ±0  190 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 19a49a4. ± Comparison against base commit 19a49a4.

@anshg1214 anshg1214 deleted the add_bb_work branch August 16, 2022 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alastair alastair alastair approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anshg1214 @alastair