Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Title for Edition Group's page #449

Merged
merged 2 commits into from
Jul 25, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ def get_edition_group_by_bbid(bbid: uuid.UUID) -> dict:
- disambiguation: Disambiguation of the edition group.
- identifiers: A list of dictionaries containing the basic information on the identifiers.
- rels: A list of dictionaries containing the basic information on the relationships.
- artist_credits: A list of dictionaries containing the basic information on the artist credits.
- author_credits: A list of dictionaries containing the basic information on the author credits.

Returns None if the edition group is not found.

Expand Down Expand Up @@ -60,7 +60,7 @@ def fetch_multiple_edition_groups(bbids: List[uuid.UUID]) -> dict:
disambiguation,
identifier_set_id,
relationship_set_id,
json_agg( acn ORDER BY "position" ASC ) as artist_credits
json_agg( acn ORDER BY "position" ASC ) as author_credits
FROM edition_group
LEFT JOIN author_credit_name acn ON acn.author_credit_id = edition_group.author_credit_id
WHERE bbid in :bbids
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
{% from 'macros.html' import show_avg_rating, entity_rate_form, show_review_buttons with context %}
{% from 'common.html' import rating_script with context %}

{% block title %}{{ edition_group.name }} - CritiqueBrainz{% endblock %}

{% block content %}
<div class="clearfix">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

{% set bb_edition_group = entity %}

{% block title %}
{{ _('Review of "%(edition_group)s" by %(user)s', edition_group=bb_edition_group.name, user=review.user.display_name) }} - CritiqueBrainz
{% endblock %}

{% block entity_title %}
<h2 id="title">
{% set edition_group_name = '<a href="%s">' | safe % url_for('bb_edition_group.entity', id=review.entity_id) ~ bb_edition_group.name ~ '</a>'|safe %}
Expand Down