Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing check for moderator CB id #416

Merged
merged 1 commit into from
Apr 6, 2022
Merged

Conversation

amCap1712
Copy link
Member

AFAIU this situation should only happen if a moderator does not have a CB account. Since, we have StrictDefined mode on we need the is defined check first. Found in local development.

AFAIU this situation should only happen if a moderator does not have a
CB account. Since, we have StrictDefined mode on we need the is defined
check first. Found in local development.
@github-actions
Copy link

github-actions bot commented Apr 6, 2022

Unit Test Results

    1 files  ±0      1 suites  ±0   1m 15s ⏱️ -5s
156 tests ±0  156 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 62cf3c8. ± Comparison against base commit 387a841.

Copy link
Collaborator

@alastair alastair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is fine, but it probably doesn't need the final and mod[]... If the item is missing if there is no cb_id, but present and filled in if there is, then just the defined check should be enough.

@alastair alastair merged commit c7e7c14 into master Apr 6, 2022
@alastair alastair deleted the missing-moderator-check branch April 6, 2022 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants