CB-406: Extract pagination logic into common component #390
Conversation
There was a problem hiding this comment.
Hi! Thanks for working on this and apologies for the late review.
The new pagination code is different from what we used originally. It looks like it allows to paginate among 5 pages at a time. I guess this way is probably fine too but any particular reason you chose to implement it this way instead of the existing previous and next buttons?
|
I chose to paginate 5 pages at a time because I felt that it is much better for easy navigation compared to the existing previous and next buttons. Also, I chose to paginate 5 pages mainly because it provides the best use. A smaller number would not add much utility, and any number greater than 5 would be too much for the user to navigate. |
| <nav aria-label="Page navigation"> | ||
| <ul class="pagination"> | ||
|
|
||
| <li class="previous {{'disabled' if current_page <= 1 }}"><a aria-label="Previous" href="{{ url_for(page_info, page=page-1, **parameter) }}">← {{ _('Previous') }}</a></li> |
There was a problem hiding this comment.
the aria-label should probably also be translated
CB-406