Fix post review API #371
Merged
Fix post review API #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
amCap1712
reviewed
Aug 22, 2021
critiquebrainz/ws/review/views.py
Outdated
| @@ -416,6 +416,7 @@ def review_post_handler(user): | |||
| """ | |||
|
|
|||
| def fetch_params(): | |||
| global REVIEW_TEXT_MIN_LENGTH | |||
There was a problem hiding this comment.
This fix looks incorrect to me. We should not be reassigning a global variable (especially which we want to asssume to be constant) while processing a request as it will be reflected in future requests. For example, a draft review may set to REVIEW_TEXT_MIN_LENGTH, then another review comes which is not a draft, since REVIEW_TEXT_MIN_LENGTH is None the minimum length check will not work as expected.
|
I have added a new fix and a test. This should hopefully fix the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a small global variable bug that caused the publish review endpoint to return an error when the review's "is_draft" was set to false.