CB-414 / CB-415: Fix issues with event artist display #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This tries to access target, which isn't there. artist['id'] is and does the trick though.
Some artists can appear multiple times, since they have the same relationship in MusicBrainz with different attributes. For example, artist -> main performer -> event (guitar, vocals). CB does not keep and display these attributes, so we are just showing the same artist entry several times with no distinguishing data. This makes sure to filter any effective duplicates out of the artists list - since it checks for equality, it should also just work and no longer dedupe the dicts if we start adding the different attributes to them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix CB-414 / CB-415
See commit messages. Both tested with https://critiquebrainz.org/event/3f0b7c79-1d66-40d2-a8a0-54be9ca2b18c