Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

French translation: Consistency and corrections #299

Closed
wants to merge 2 commits into from
Closed

French translation: Consistency and corrections #299

wants to merge 2 commits into from

Conversation

jesus2099
Copy link

  • Consistency of punctuation and of some expressions
  • Some corrections
  • Homogénéisations des ponctuations et de quelques expressions
  • Quelques corrections

@jesus2099
Consistency and corrections
71e0513 
- Consistency of punctuation and of some expressions
- Some corrections

---

- Homogénéisations des ponctuations et de quelques expressions
- Quelques corrections
@alastair
Copy link
Collaborator

Translations for critiquebrainz are handled in transifex: https://critiquebrainz.readthedocs.io/translation.html
Could you please apply these changes there? Merçi!

@jesus2099
Copy link
Author

Oh Transifex is my Nightmare.
But now I see in https://www.transifex.com/musicbrainz/critiquebrainz/critiquebrainz/ when I click French, that I can download this messages.po for translation.
Then I will probably be able to re-upload the modified file. 🤞

We will close this PR, right?

@jesus2099
Copy link
Author

I think I managed to re-upload my modified file to Transifex, including fixing my 2 mistakes.
Please close this PR if there is nothing else to do. :)

@jesus2099
Copy link
Author

@alastair, I leave it up to you to close this PR once you import Transifex updates? :)

@alastair
Copy link
Collaborator

Thanks, I'll keep the PR open until I work out how to sync transifex.

@jesus2099
Copy link
Author

Yes. 😉

I don't understand transifex. Over there, there are only autoedits, including massive batch autoedits like I did.
I don't see how it can be reviewed, over there.
To me, it would be more simple to manage translations through GitHub PR.

@jesus2099
Copy link
Author

I went to CritiqueBrainz.org and saw the most obvious typo I had fixed is still not deployed:

Footer:
Projet de 1MetaBrainz Foundation

So I guess none of my changes are replicated yet.

I hope you have an easy way to review changes in Transifex.
I did not find anything handy like https://github.com/metabrainz/critiquebrainz/pull/299/files

@alastair
Copy link
Collaborator

@jesus2099 I finally pulled your translations from transifex: #345
Sorry for the delay, and thanks again!

@alastair alastair closed this Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alastair alastair alastair left review comments

@zas zas zas requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jesus2099 @alastair @zas