Fix uWSGI configuration for clean shutdown

As per investigation, we can remove exit-on-reload and use the array form of the command to ensure proper signal handling on reloads.
metabrainz · Nov 28, 2023 · 3c8ae89 · 3c8ae89
1 parent 3d19c40
commit 3c8ae89
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/docker/prod/consul-template-redirect.conf b/docker/prod/consul-template-redirect.conf
@@ -5,7 +5,7 @@ template {
 }
 
 exec {
-    command = "chpst -u art:art /home/art/.local/bin/uwsgi /etc/uwsgi/uwsgi.ini"
+    command = ["chpst", "-u", "art:art", "/home/art/.local/bin/uwsgi", "/etc/uwsgi/uwsgi.ini"]
     splay = "10s"
     reload_signal = "SIGHUP"
     kill_signal = "SIGTERM"

diff --git a/docker/prod/uwsgi.ini b/docker/prod/uwsgi.ini
@@ -14,5 +14,3 @@ reload-mercy = 25
 log-x-forwarded-for=true
 ; quit uwsgi if the python app fails to load
 need-app = true
-; when uwsgi gets a sighup, quit completely and let runit restart us
-exit-on-reload = true