Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Expand platform support #43

Merged
merged 23 commits into from
Aug 5, 2024
Merged

Conversation

umgefahren
Copy link

@umgefahren umgefahren commented Aug 5, 2024

This PR introduces better support for Tier2 and Tier3 (apple) targets including:

  • macOS
  • iOS
  • watchOS
  • tvOS
  • visionOS
  • FreeBSD
  • NetBSD
  • OpenBSD

Resolves: #42

The CI was updated to reflect more modern practices, while compile tests for the new platforms where added.

Additionally now cfg flags are visible in docsrs through the introduction of nightly only, but available on docs.rs, documentation.

@umgefahren umgefahren changed the title feat: Better Apple support feat: Expand platform support Aug 5, 2024
Copy link
Owner

@messense messense left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot!

@messense messense merged commit 605f750 into messense:master Aug 5, 2024
16 checks passed
@umgefahren umgefahren deleted the apple-support branch August 5, 2024 08:59
@SludgePhD
Copy link

This PR broke the docs.rs build of if-addrs. It is now complaining about a cfg directive because it is missing a ,:

[INFO] [stderr] error: expected one of `)` or `,`, found `not`
[INFO] [stderr]    --> src/lib.rs:437:9
[INFO] [stderr]     |
[INFO] [stderr] 436 |         not(target_os = "netbsd")
[INFO] [stderr]     |                                  -
[INFO] [stderr]     |                                  |
[INFO] [stderr]     |                                  expected one of `)` or `,`
[INFO] [stderr]     |                                  help: missing `,`
[INFO] [stderr] 437 |         not(target_os = "openbsd")
[INFO] [stderr]     |         ^^^ unexpected token

@umgefahren umgefahren restored the apple-support branch August 18, 2024 23:19
umgefahren added a commit to umgefahren/if-addrs that referenced this pull request Aug 18, 2024
@umgefahren
Copy link
Author

This PR broke the docs.rs build of if-addrs. It is now complaining about a cfg directive because it is missing a ,:

[INFO] [stderr] error: expected one of `)` or `,`, found `not`
[INFO] [stderr]    --> src/lib.rs:437:9
[INFO] [stderr]     |
[INFO] [stderr] 436 |         not(target_os = "netbsd")
[INFO] [stderr]     |                                  -
[INFO] [stderr]     |                                  |
[INFO] [stderr]     |                                  expected one of `)` or `,`
[INFO] [stderr]     |                                  help: missing `,`
[INFO] [stderr] 437 |         not(target_os = "openbsd")
[INFO] [stderr]     |         ^^^ unexpected token

Thank you so much for finding that, I'm really sorry I caused that. I have opened #45 introducing a fix and bumping the version allowing for new publishing on crates.io.

messense pushed a commit that referenced this pull request Aug 19, 2024
* docs.rs hotfix for bug introduced in #43

* Bump version for new release on docs.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unresolved imports libc::sockaddr_nl, libc::AF_NETLINK, libc::NETLINK_ROUTE on freebsd
3 participants