Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kubernetes-dashboard): Make deployable on gke #2411

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

gracedo
Copy link
Contributor

@gracedo gracedo commented Jul 15, 2024

What problem does this PR solve?:
awsgke e2e tests are failing on kubernetes-dashboard failing to come up ready. Trying to see how to fix it.
Also, found a few indentation errors in values.yaml

Which issue(s) does this PR fix?:

https://jira.nutanix.com/browse/NCN-101453

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Checklist

  • If the PR adds a version bump, ensure there is no breaking change in Licensing model (or NA).
  • If a chart is changed or app configuration is significantly changed, the chart version is correctly incremented (so that apps are not automatically upgraded from a previous version of DKP).

@gracedo gracedo added the ok-to-test Signals mergebot that CI checks are ready to be kicked off label Jul 15, 2024
@gracedo gracedo self-assigned this Jul 15, 2024
@github-actions github-actions bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. services/kubernetes-dashboard update-licenses signals mergebot to update licenses.d2iq.yaml and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 15, 2024
@gracedo gracedo force-pushed the gracedo/k8sdash_NCN-101453 branch from 5c92eb1 to 1eab5b0 Compare July 15, 2024 18:01
@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 15, 2024
@coveralls
Copy link

coveralls commented Jul 15, 2024

Pull Request Test Coverage Report for Build 9947153531

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 51.515%

Totals Coverage Status
Change from base Build 9944214020: 0.0%
Covered Lines: 136
Relevant Lines: 264

💛 - Coveralls

@gracedo gracedo force-pushed the gracedo/k8sdash_NCN-101453 branch from 1eab5b0 to 2691813 Compare July 15, 2024 21:50
@gracedo
Copy link
Contributor Author

gracedo commented Jul 15, 2024

https://github.com/mesosphere/kommander-e2e/actions/runs/9934481399/job/27479599613#logs I tagged my branch as v2.12.0-dev and reran the e2e nightly test suite, and this got the awsgke test passing

I made the config change that was suggested in kubernetes/dashboard#8765 (comment)

@gracedo gracedo marked this pull request as ready for review July 15, 2024 23:16
@gracedo gracedo requested a review from lukeogg July 15, 2024 23:16
@gracedo gracedo enabled auto-merge (squash) July 15, 2024 23:17
@gracedo gracedo requested review from takirala and cwyl02 July 16, 2024 00:00
@gracedo gracedo merged commit 348c295 into main Jul 16, 2024
44 checks passed
@gracedo gracedo deleted the gracedo/k8sdash_NCN-101453 branch July 16, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Signals mergebot that CI checks are ready to be kicked off ready-for-review services/kubernetes-dashboard size/M Denotes a PR that changes 30-99 lines, ignoring generated files. update-licenses signals mergebot to update licenses.d2iq.yaml
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants