programs: Store the project version when overriding find_program #13714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirbheek
force-pushed
the
File-program-version
branch
2 times, most recently
from
abdba2b
to
aa0efb9
Compare
dcbaker
reviewed
Sep 27, 2024
nirbheek
force-pushed
the
File-program-version
branch
from
aa0efb9
to
677c83a
Compare
|
Will merge in 24h if there are no objections. |
When we're using the output of configure_file() with override_find_program(), we weren't storing the version anywhere, so get_version() was trying to run the script during setup. This is usually fine, except in cases where the configure_file() script actually has to import a library built as part of the project, and fails to run. For built executables, we simply use the project version, and we now do the same here too.
nirbheek
force-pushed
the
File-program-version
branch
from
677c83a
to
a1dc06c
Compare
dcbaker
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we're using the output of
configure_file()withoverride_find_program(), we weren't storing the version anywhere, soget_version()was trying to run the script during setup.This is usually fine, except in cases where the
configure_file()script actually has to import a library built as part of the project, and fails to run.For built executables, we simply use the project version, and we now do the same here too.